]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: Fix use of uninitialized MPS value
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 29 Apr 2014 18:51:55 +0000 (12:51 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 29 Apr 2014 23:36:44 +0000 (17:36 -0600)
commit0a4ec05c03443f53a6ab97957da399460cdfaaec
tree3ac5fcf7100d63dc4aad0e8ba6392353f56c5458
parent30a796dca00fafffda5f0b739305a2444311896c
PCI: Fix use of uninitialized MPS value

If "pcie_bus_config == PCIE_BUS_PERFORMANCE", we don't initialize "smpss",
so we pass a pointer to garbage into pcie_bus_configure_set(), where we
compute "mps" based on the garbage.  We then pass the garbage "mps" to
pcie_write_mps(), which ignores it in the PCIE_BUS_PERFORMANCE case.

Coverity isn't smart enough to deduce that we ignore the garbage (it's a
lot to expect from a human, too), so initialize "smpss" to a safe value in
all cases.

Found by Coverity (CID 146454).

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/probe.c