]> git.baikalelectronics.ru Git - kernel.git/commit
drm/self_refresh: Fix possible NULL deref in failure path
authorSean Paul <seanpaul@chromium.org>
Wed, 19 Jun 2019 18:19:47 +0000 (14:19 -0400)
committerSean Paul <seanpaul@chromium.org>
Thu, 20 Jun 2019 14:03:21 +0000 (10:03 -0400)
commit0a03d006c80c4b5d6c790852e19cc5015581ea86
tree76e033a4c13b48524f47b27733e581fc952ed73a
parenta4fd65c1d9fe27439c4fad6e3c2b1232160587d1
drm/self_refresh: Fix possible NULL deref in failure path

If state allocation fails, we still try to give back the reference on
it. Also initialize ret in case the crtc is not enabled and we hit the
eject button.

Fixes: 43bf3d09c0fd ("drm: Add helpers to kick off self refresh mode in drivers")
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jose Souza <jose.souza@intel.com>
Cc: Zain Wang <wzz@rock-chips.com>
Cc: Tomasz Figa <tfiga@chromium.org>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190619181951.192305-1-sean@poorly.run
drivers/gpu/drm/drm_self_refresh_helper.c