]> git.baikalelectronics.ru Git - kernel.git/commit
ethtool: exit the loop when invalid index occurs
authorJean Sacren <sakiwit@gmail.com>
Sun, 27 Apr 2014 08:20:38 +0000 (02:20 -0600)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Apr 2014 17:28:43 +0000 (13:28 -0400)
commit098108fc50be5895960b77d89bf2172e05d6a177
treea7cc7f9a4b18cb5654d05f9a77b29eb5a3e91c00
parent7b7903677a28dbc9a0636a4e962edb8610664f9a
ethtool: exit the loop when invalid index occurs

The commit 12a3e3c86823 ("ethtool: Support for configurable RSS hash
key") introduced a new function ethtool_copy_validate_indir() with
full iteration of the loop to validate the ring indices, which could
be an overkill. To minimize the impact, we ought to exit the loop as
soon as the invalid index occurs for the very first time. The
remaining loop simply doesn't serve any more purpose.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Cc: Venkata Duvvuru <VenkatKumar.Duvvuru@Emulex.Com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c