]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT
authorKevin Hilman <khilman@ti.com>
Wed, 11 Jul 2012 21:02:44 +0000 (14:02 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 11 Jul 2012 23:04:48 +0000 (16:04 -0700)
commit08eb1f09ef21e14274e612cfac166d4f7aee43fa
tree764e16ae7d9d00fcc1f8d673587a01be59089689
parent86c0351fcf38e448238c85c61211412fa64d3c85
drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT

Requesting a threaded interrupt without a primary handler and without
IRQF_ONESHOT is dangerous, and after commit ac4ffb5f ("genirq: Reject
bogus threaded irq requests"), these requests are rejected.  This causes
->probe() to fail, and the RTC driver not to be availble.

To fix, add IRQF_ONESHOT to the IRQ flags.

Tested on OMAP3730/OveroSTORM and OMAP4430/Panda board using rtcwake to
wake from system suspend multiple times.

Signed-off-by: Kevin Hilman <khilman@ti.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-twl.c