]> git.baikalelectronics.ru Git - kernel.git/commit
tpm_tis: Fix IRQ autoprobing when using platform_device
authorJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Thu, 4 May 2017 15:53:23 +0000 (09:53 -0600)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tue, 13 Jun 2017 19:02:08 +0000 (22:02 +0300)
commit08e79f5a40eac4ef6d06634f473ad1138ca774b3
tree8b3e9e24ffc4106dcb13058f64ec3369d94d063c
parent72602a28b5b4f7a5869f9c8040be9ef5d660b031
tpm_tis: Fix IRQ autoprobing when using platform_device

The test was backwards, triggering IRQ autoprobing if the firmware
did not specify an IRQ, instead of triggering it only when the
module force parameter was specified.

Since autoprobing is not enabled on !x86 and the platform device is
currently only used on !x86, or with force, this has gone unnoticed.

Fixes: e69521cf1326 ("tpm_tis: Clean up the force=1 module parameter")
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jerry Snitselaar <jsnitsel@redhat.com> (with TPM 2.0)
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> (with TPM 1.2)
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm_tis.c