]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: Do not perform software reset for Generic PHY
authorFlorian Fainelli <f.fainelli@gmail.com>
Sun, 5 Mar 2017 20:34:49 +0000 (12:34 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Mar 2017 01:57:27 +0000 (17:57 -0800)
commit0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6
tree5e5a0765be73afca26e683014671e4b884d9695a
parentf38837b08d23e66de17d46d030e0d9ac5172ad1f
net: phy: Do not perform software reset for Generic PHY

The Generic PHY driver is a catch-all PHY driver and it should preserve
whatever prior initialization has been done by boot loader or firmware
agents. For specific PHY device configuration it is expected that a
specialized PHY driver would take over that role.

Resetting the generic PHY was a bad idea that has lead to several
complaints and downstream workarounds e.g: in OpenWrt/LEDE so restore
the behavior prior to 87aa9f9c61ad ("net: phy: consolidate PHY
reset in phy_init_hw()").

Reported-by: Felix Fietkau <nbd@nbd.name>
Fixes: 87aa9f9c61ad ("net: phy: consolidate PHY reset in phy_init_hw()")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy_device.c
include/linux/phy.h