]> git.baikalelectronics.ru Git - kernel.git/commit
usb: dwc3: gadget: Disable gadget IRQ during pullup disable
authorWesley Cheng <wcheng@codeaurora.org>
Fri, 21 May 2021 04:23:57 +0000 (21:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 Jun 2021 14:47:08 +0000 (16:47 +0200)
commit0861a266c85b11220d6011413558fe45c8490887
treec29dc974670130489e0cfcb8822c12917e243a14
parentaca98666aaa2f68c1752cba973556812e3a190eb
usb: dwc3: gadget: Disable gadget IRQ during pullup disable

Current sequence utilizes dwc3_gadget_disable_irq() alongside
synchronize_irq() to ensure that no further DWC3 events are generated.
However, the dwc3_gadget_disable_irq() API only disables device
specific events.  Endpoint events can still be generated.  Briefly
disable the interrupt line, so that the cleanup code can run to
prevent device and endpoint events. (i.e. __dwc3_gadget_stop() and
dwc3_stop_active_transfers() respectively)

Without doing so, it can lead to both the interrupt handler and the
pullup disable routine both writing to the GEVNTCOUNT register, which
will cause an incorrect count being read from future interrupts.

Fixes: d1ed52393959 ("usb: dwc3: Stop active transfers before halting the controller")
Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
Link: https://lore.kernel.org/r/1621571037-1424-1-git-send-email-wcheng@codeaurora.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/gadget.c