]> git.baikalelectronics.ru Git - kernel.git/commit
USB: xhci - fix bit definitions for IMAN register
authorDmitry Torokhov <dtor@vmware.com>
Mon, 25 Feb 2013 18:56:01 +0000 (10:56 -0800)
committerSarah Sharp <sarah.a.sharp@linux.intel.com>
Mon, 18 Mar 2013 15:25:13 +0000 (08:25 -0700)
commit085c68fcfbb076a1198a937d1c5fb48af3da126b
tree5d98d5c4bec3fb3e014e77204b68430a3e99e9a8
parent07702d5370b02e8630beb7f5d5beb014cc72be5c
USB: xhci - fix bit definitions for IMAN register

According to XHCI specification (5.5.2.1) the IP is bit 0 and IE is bit 1
of IMAN register. Previously their definitions were reversed.

Even though there are no ill effects being observed from the swapped
definitions (because IMAN_IP is RW1C and in legacy PCI case we come in
with it already set to 1 so it was clearing itself even though we were
setting IMAN_IE instead of IMAN_IP), we should still correct the values.

This patch should be backported to kernels as old as 2.6.36, that
contain the commit 7fba20e620c9fa999ec88078ecb76d6557698bd0 "xhci: don't
re-enable IE constantly".

Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: stable@vger.kernel.org
drivers/usb/host/xhci.h