]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "macvlan : fix checksums error when we are in bridge mode"
authorVlad Yasevich <vyasevic@redhat.com>
Tue, 29 Apr 2014 14:09:51 +0000 (10:09 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Apr 2014 20:12:22 +0000 (16:12 -0400)
commit08423819d76cbb1ad4f1e3765563a77105804905
tree133b67f68082c1787d947455bb8e39de716ea7c9
parentd6fabe52dd802ba1ce50224c6f37bc75372893fb
Revert "macvlan : fix checksums error when we are in bridge mode"

This reverts commit 1418c983d706cc3dc9041114222caa0390cb7808.
The commit above doesn't appear to be necessary any more as the
checksums appear to be correctly computed/validated.

Additionally the above commit breaks kvm configurations where
one VM is using a device that support checksum offload (virtio) and
the other VM does not.
In this case, packets leaving virtio device will have CHECKSUM_PARTIAL
set.  The packets is forwarded to a macvtap that has offload features
turned off.  Since we use CHECKSUM_UNNECESSARY, the host does does not
update the checksum and thus a bad checksum is passed up to
the guest.

CC: Daniel Lezcano <daniel.lezcano@free.fr>
CC: Patrick McHardy <kaber@trash.net>
CC: Andrian Nord <nightnord@gmail.com>
CC: Eric Dumazet <eric.dumazet@gmail.com>
CC: Michael S. Tsirkin <mst@redhat.com>
CC: Jason Wang <jasowang@redhat.com>
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macvlan.c