]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: use sector_div instead of do_div
authorArnd Bergmann <arnd@arndb.de>
Fri, 20 Nov 2015 16:38:28 +0000 (17:38 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 26 Nov 2015 03:17:02 +0000 (22:17 -0500)
commit08356190a2ffe0aab65e71f5ad1ba38c43ee1b33
tree92cbf3a0415f542f6938988e6512f9fbaaead5e3
parent3c7a7548f417f3c763edbe2a0ddec3f40e795785
scsi: use sector_div instead of do_div

do_div is the wrong way to divide a sector_t, as it is less efficient
when sector_t is 32-bit wide. With the upcoming do_div optimizations,
the kernel starts warning about this:

drivers/scsi/scsi_debug.c: In function 'dif_store':
include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast

This changes the code to use sector_div instead, which always produces
optimal code.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Hannes Reinicke <hare@suse.de>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_debug.c