]> git.baikalelectronics.ru Git - kernel.git/commit
proc: Put thread_pid in release_task not proc_flush_pid
authorEric W. Biederman <ebiederm@xmission.com>
Fri, 24 Apr 2020 20:41:20 +0000 (15:41 -0500)
committerEric W. Biederman <ebiederm@xmission.com>
Fri, 24 Apr 2020 20:49:00 +0000 (15:49 -0500)
commit07e306b3a1d6e55720bd2ac75b59eb42b10e701b
treebcbb3ed8d7cb60920556673bd571a8206c21e759
parent789803d5750ea3aa09215e24d46609b27638a231
proc: Put thread_pid in release_task not proc_flush_pid

Oleg pointed out that in the unlikely event the kernel is compiled
with CONFIG_PROC_FS unset that release_task will now leak the pid.

Move the put_pid out of proc_flush_pid into release_task to fix this
and to guarantee I don't make that mistake again.

When possible it makes sense to keep get and put in the same function
so it can easily been seen how they pair up.

Fixes: a8c0c0ea9e09 ("proc: Use a list of inodes to flush from proc")
Reported-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
fs/proc/base.c
kernel/exit.c