]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: arm/arm64: Only skip MMIO insn once
authorAndrew Jones <drjones@redhat.com>
Thu, 22 Aug 2019 11:03:05 +0000 (13:03 +0200)
committerMarc Zyngier <maz@kernel.org>
Thu, 22 Aug 2019 12:19:56 +0000 (13:19 +0100)
commit077eb8e270704cb7008891bd76baae01c78a0bef
tree348406b3194e49fb49bba929fcaae8f2ba1bca13
parent5c9fc473d0bb0c98ab94d78c8b5b99286d6e7761
KVM: arm/arm64: Only skip MMIO insn once

If after an MMIO exit to userspace a VCPU is immediately run with an
immediate_exit request, such as when a signal is delivered or an MMIO
emulation completion is needed, then the VCPU completes the MMIO
emulation and immediately returns to userspace. As the exit_reason
does not get changed from KVM_EXIT_MMIO in these cases we have to
be careful not to complete the MMIO emulation again, when the VCPU is
eventually run again, because the emulation does an instruction skip
(and doing too many skips would be a waste of guest code :-) We need
to use additional VCPU state to track if the emulation is complete.
As luck would have it, we already have 'mmio_needed', which even
appears to be used in this way by other architectures already.

Fixes: 90fb317071b4 ("arm64: KVM: Skip MMIO insn after emulation")
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
virt/kvm/arm/mmio.c