]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: fix get_hw_feature() on old hardware
authorHerve Codina <herve.codina@bootlin.com>
Fri, 8 Oct 2021 10:34:37 +0000 (12:34 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Oct 2021 15:22:38 +0000 (16:22 +0100)
commit075da584bae2da6a37428d59a477b6bdad430ac3
tree5c0300839c82134246d9d0440a120abcfda9cd95
parent612f71d7328c14369924384ad2170aae2a6abd92
net: stmmac: fix get_hw_feature() on old hardware

Some old IPs do not provide the hardware feature register.
On these IPs, this register is read 0x00000000.

In old driver version, this feature was handled but a regression came
with the commit f10a6a3541b4 ("stmmac: rework get_hw_feature function").
Indeed, this commit removes the return value in dma->get_hw_feature().
This return value was used to indicate the validity of retrieved
information and used later on in stmmac_hw_init() to override
priv->plat data if this hardware feature were valid.

This patch restores the return code in ->get_hw_feature() in order
to indicate the hardware feature validity and override priv->plat
data only if this hardware feature is valid.

Fixes: f10a6a3541b4 ("stmmac: rework get_hw_feature function")
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c
drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
drivers/net/ethernet/stmicro/stmmac/hwif.h