]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: rtsx_usb_sdmmc: fix incorrect last byte in R2 response
authorRoger Tseng <rogerable@realtek.com>
Fri, 15 Aug 2014 06:06:01 +0000 (14:06 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 9 Sep 2014 11:59:02 +0000 (13:59 +0200)
commit070147bb1b5d75ceceac64d1f38ee5a726ad7fa0
tree3d57dafc0ea57b98bf5686f2e24cbed02439cda1
parentf0334b86a2d6a5ca7a06e704e26b709c7511bc70
mmc: rtsx_usb_sdmmc: fix incorrect last byte in R2 response

Current code erroneously fill the last byte of R2 response with an undefined
value. In addition, the controller actually 'offloads' the last byte
(CRC7, end bit) while receiving R2 response and thus it's impossible to get the
actual value. This could cause mmc stack to obtain inconsistent CID from the
same card after resume and misidentify it as a different card.

Fix by assigning dummy CRC and end bit: {7'b0, 1} = 0x1 to the last byte of R2.

Cc: <stable@vger.kernel.org> # v3.16+
Fixes: 135a3d8da9e6 ("mmc: Add realtek USB sdmmc host driver")
Signed-off-by: Roger Tseng <rogerable@realtek.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/rtsx_usb_sdmmc.c