]> git.baikalelectronics.ru Git - kernel.git/commit
mptcp: always parse mptcp options for MPC reqsk
authorPaolo Abeni <pabeni@redhat.com>
Thu, 27 May 2021 23:31:38 +0000 (16:31 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 28 May 2021 20:51:40 +0000 (13:51 -0700)
commit06f9a435b3aa12f4de6da91f11fdce8ce7b46205
treeafdc0c71ee72a485b5fa359e5139855b1ffacb06
parentb5941f066b4ca331db225a976dae1d6ca8cf0ae3
mptcp: always parse mptcp options for MPC reqsk

In subflow_syn_recv_sock() we currently skip options parsing
for OoO packet, given that such packets may not carry the relevant
MPC option.

If the peer generates an MPC+data TSO packet and some of the early
segments are lost or get reorder, we server will ignore the peer key,
causing transient, unexpected fallback to TCP.

The solution is always parsing the incoming MPTCP options, and
do the fallback only for in-order packets. This actually cleans
the existing code a bit.

Fixes: d22f4988ffec ("mptcp: process MP_CAPABLE data option")
Reported-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/subflow.c