]> git.baikalelectronics.ru Git - kernel.git/commit
posix-cpu-timers: Cleanup CPU timers before freeing them during exec
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Tue, 9 Aug 2022 17:07:51 +0000 (14:07 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:24:19 +0000 (14:24 +0200)
commit06a2b06ba3d8ca48cf32e635bde32427eb1e97dc
tree679c62b1a91840249e5b6a37b9262f4ef6fcd246
parentc2dacbec9b448edc46b87d98e2aa2b94387c3798
posix-cpu-timers: Cleanup CPU timers before freeing them during exec

commit af5644453e8833d9af643205ee20d42635114cb3 upstream.

Commit 52a323cd661b ("posix-cpu-timers: Store a reference to a pid not a
task") started looking up tasks by PID when deleting a CPU timer.

When a non-leader thread calls execve, it will switch PIDs with the leader
process. Then, as it calls exit_itimers, posix_cpu_timer_del cannot find
the task because the timer still points out to the old PID.

That means that armed timers won't be disarmed, that is, they won't be
removed from the timerqueue_list. exit_itimers will still release their
memory, and when that list is later processed, it leads to a
use-after-free.

Clean up the timers from the de-threaded task before freeing them. This
prevents a reported use-after-free.

Fixes: 52a323cd661b ("posix-cpu-timers: Store a reference to a pid not a task")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220809170751.164716-1-cascardo@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/exec.c