]> git.baikalelectronics.ru Git - kernel.git/commit
pch_gbe: Fix build error by selecting all the possible dependencies.
authorHaicheng Li <haicheng.lee@gmail.com>
Mon, 8 Oct 2012 23:43:12 +0000 (23:43 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Oct 2012 17:50:56 +0000 (13:50 -0400)
commit067e7e002ed5d639d9edf051b0aa2d1e9d050644
tree8eb6f595c348fbf526edee183c024b80fe431a96
parentf41488dd11dca8e819366a4ec4a53a590633e226
pch_gbe: Fix build error by selecting all the possible dependencies.

Fengguang reported a kernel build failure as following:
drivers/built-in.o: In function `pch_gbe_ioctl':
pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write'
pch_gbe_main.c:(.text+0x510393): undefined reference to `pch_ch_control_write'
pch_gbe_main.c:(.text+0x5103b3): undefined reference to `pch_ch_control_write'
...

It's a regression by commit 486882fc1. The root cause is that
the CONFIG_PPS is not set there, consequently CONFIG_PTP_1588_CLOCK
can not be set anyway, which finally causes ptp_pch and pch_gbe_main
build failures.

As David prefers to use *select* to fix such module co-dependency issues,
this patch explicitly selects all the possible dependencies of PCH_PTP.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Haicheng Li <haicheng.lee@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/oki-semi/pch_gbe/Kconfig