]> git.baikalelectronics.ru Git - kernel.git/commit
spi/spi-{bcm63xx.c,bfin-v3.c}: simplify use of devm_ioremap_resource
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 14 Aug 2013 09:11:09 +0000 (11:11 +0200)
committerMark Brown <broonie@linaro.org>
Wed, 14 Aug 2013 16:47:58 +0000 (17:47 +0100)
commit061d59ba99a3825b9ad25d4fbb2741ae457d3c99
treea0fd8710f14d1c658954311db01c95a6319dd945
parent704589eaf16a3f680c2b3f3f4ba92ffb04e388af
spi/spi-{bcm63xx.c,bfin-v3.c}: simplify use of devm_ioremap_resource

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-bcm63xx.c
drivers/spi/spi-bfin-v3.c