]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: Fix optional-arg mount options
authorEric Sandeen <sandeen@redhat.com>
Tue, 16 Feb 2010 01:17:55 +0000 (20:17 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 16 Feb 2010 01:17:55 +0000 (20:17 -0500)
commit05f64850ceff5df0efb60728ed969c1dc7594674
tree50861d9444cd21945a6086fa03c2bdd1a7f8c354
parentdfb5bccd1b68cad5ec79a643fe8d05d3e68b8f06
ext4: Fix optional-arg mount options

We have 2 mount options, "barrier" and "auto_da_alloc" which may or
may not take a 1/0 argument.  This causes the ext4 superblock mount
code to subtract uninitialized pointers and pass the result to
kmalloc, which results in very noisy failures.

Per Ted's suggestion, initialize the args struct so that
we know whether match_token() found an argument for the
option, and skip match_int() if not.

Also, return error (0) from parse_options if we thought
we found an argument, but match_int() Fails.

Reported-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/super.c