]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: Do not leave DSA master with NULL netdev_ops
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 4 May 2020 20:18:06 +0000 (13:18 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 May 2020 00:31:54 +0000 (17:31 -0700)
commit050569fc8384c8056bacefcc246bcb2dfe574936
tree6b4fd984dc23bfc5a0d090b8194db878fc67f8c7
parent657221598f820ff860972b67583fb91d9ab7caf4
net: dsa: Do not leave DSA master with NULL netdev_ops

When ndo_get_phys_port_name() for the CPU port was added we introduced
an early check for when the DSA master network device in
dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When
we perform the teardown operation in dsa_master_ndo_teardown() we would
not be checking that cpu_dp->orig_ndo_ops was successfully allocated and
non-NULL initialized.

With network device drivers such as virtio_net, this leads to a NPD as
soon as the DSA switch hanging off of it gets torn down because we are
now assigning the virtio_net device's netdev_ops a NULL pointer.

Fixes: da7b9e9b00d4 ("net: dsa: Add ndo_get_phys_port_name() for CPU port")
Reported-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/master.c