]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "mm/gup: small refactoring: simplify try_grab_page()"
authorJohn Hubbard <jhubbard@nvidia.com>
Wed, 2 Feb 2022 03:23:17 +0000 (19:23 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 3 Feb 2022 14:51:42 +0000 (06:51 -0800)
commit047dbce5d6682ef2d17d8863e71ddb767676b1d9
tree749938c541b52a6b432c1fd06493d42216320adb
parentf2493b25ce0e8aa5a7341ec75f32829a23f372ce
Revert "mm/gup: small refactoring: simplify try_grab_page()"

This reverts commit 184128408b89b804c45d80e71b416366bd49fe6f

That commit did a refactoring that effectively combined fast and slow
gup paths (again).  And that was again incorrect, for two reasons:

 a) Fast gup and slow gup get reference counts on pages in different
    ways and with different goals: see Linus' writeup in commit
    06559c7f1be8 ("Revert "mm/gup: remove try_get_page(), call
    try_get_compound_head() directly""), and

 b) try_grab_compound_head() also has a specific check for
    "FOLL_LONGTERM && !is_pinned(page)", that assumes that the caller
    can fall back to slow gup. This resulted in new failures, as
    recently report by Will McVicker [1].

But (a) has problems too, even though they may not have been reported
yet.  So just revert this.

Link: https://lore.kernel.org/r/20220131203504.3458775-1-willmcvicker@google.com
Fixes: 184128408b89 ("mm/gup: small refactoring: simplify try_grab_page()")
Reported-and-tested-by: Will McVicker <willmcvicker@google.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Minchan Kim <minchan@google.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: stable@vger.kernel.org # 5.15
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/gup.c