]> git.baikalelectronics.ru Git - kernel.git/commit
nvme-fabrics: Ignore nr_io_queues option for discovery controllers
authorRoland Dreier <roland@purestorage.com>
Mon, 5 Mar 2018 19:59:53 +0000 (11:59 -0800)
committerKeith Busch <keith.busch@intel.com>
Thu, 8 Mar 2018 16:19:17 +0000 (09:19 -0700)
commit0475821e229cfd9954b7501113d1acbc57b68689
treefdf813d8b60669383cff0a9e92752ea91e763552
parent8a30ecc6e0ecbb9ae95daf499b2680b885ed0349
nvme-fabrics: Ignore nr_io_queues option for discovery controllers

This removes a dependency on the order options are passed when creating
a fabrics controller.  With the old code, if "nr_io_queues" appears before
an "nqn" option specifying the discovery controller, then nr_io_queues
is overridden with zero.  If "nr_io_queues" appears after specifying the
discovery controller, then the nr_io_queues option is used to set the
number of queues, and the driver attempts to establish IO connections
to the discovery controller (which doesn't work).

It seems better to ignore (and warn about) the "nr_io_queues" option
if userspace has already asked to connect to the discovery controller.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Reviewed-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <keith.busch@intel.com>
drivers/nvme/host/fabrics.c