]> git.baikalelectronics.ru Git - kernel.git/commit
[PATCH] IDE error handling fixes
authorHua Zhong <hzhong@gmail.com>
Tue, 3 Oct 2006 08:14:15 +0000 (01:14 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 3 Oct 2006 15:04:07 +0000 (08:04 -0700)
commit03cb6c86f9b97fe9f53f43907534233604e5d3f1
tree16d9b0bc3a5bd30c69b03836d44c1db4338628c4
parent87c154deb9147f800ea7cd1c9a93fa377a327d6a
[PATCH] IDE error handling fixes

In 2.6.15.1 I encountered some IDE crashes when unplugging IDE cables to
emulate disk errors.  Below is a patch against 2.6.16 which I think still
applies.

1.  The first BUG_ON could trigger when a PREFLUSH IO fails (it would
   fail the original barrier request which hasn't been marked REQ_STARTED
   yet).

2. the rq could have been dequeued already (same as 1).

3.  HWGROUP(drive)->rq could be NULL because of the ide_error() several
   lines earlier.

Signed-off-by: Hua Zhong <hzhong@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/ide/ide-io.c