]> git.baikalelectronics.ru Git - kernel.git/commit
perf tools: Account entry stats when it's added to the output tree
authorNamhyung Kim <namhyung@kernel.org>
Tue, 22 Apr 2014 02:44:21 +0000 (11:44 +0900)
committerJiri Olsa <jolsa@kernel.org>
Thu, 24 Apr 2014 14:32:15 +0000 (16:32 +0200)
commit02b91ccc522e414adeb2db84c8df382fe1344af2
treeafb1ff42a151339c55782af3b626078a81b21fd1
parente51ef3346f79baf2561974c43325c133e028f993
perf tools: Account entry stats when it's added to the output tree

Currently, accounting each sample is done in multiple places - once
when adding them to the input tree, other when adding them to the
output tree.  It's not only confusing but also can cause a subtle
problem since concurrent processing like in perf top might see the
updated stats before adding entries into the output tree - like seeing
more (blank) lines at the end and/or slight inaccurate percentage.

To fix this, only account the entries when it's moved into the output
tree so that they cannot be seen prematurely.  There're some
exceptional cases here and there - they should be addressed separately
with comments.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1398327843-31845-7-git-send-email-namhyung@kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
tools/perf/builtin-annotate.c
tools/perf/builtin-diff.c
tools/perf/builtin-report.c
tools/perf/util/hist.c