]> git.baikalelectronics.ru Git - kernel.git/commit
platform/surface: dtx: Fix poll function
authorMaximilian Luz <luzmaximilian@gmail.com>
Thu, 13 May 2021 13:44:37 +0000 (15:44 +0200)
committerHans de Goede <hdegoede@redhat.com>
Wed, 19 May 2021 13:24:52 +0000 (15:24 +0200)
commit02a6e8af9c93636833e53a7831b3c5060bb2f891
treea023cf34361601f6d60cfe8116cdb250550bceba
parentb65132eaf9c77d95ee7e087be910028eb79de35a
platform/surface: dtx: Fix poll function

The poll function should not return -ERESTARTSYS.

Furthermore, locking in this function is completely unnecessary. The
ddev->lock protects access to the main device and controller (ddev->dev
and ddev->ctrl), ensuring that both are and remain valid while being
accessed by clients. Both are, however, never accessed in the poll
function. The shutdown test (via atomic bit flags) be safely done
without locking, so drop locking here entirely.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 1a2f46018001 ("platform/surface: Add DTX driver)
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210513134437.2431022-1-luzmaximilian@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/surface/surface_dtx.c