]> git.baikalelectronics.ru Git - kernel.git/commit
spi: spi-topcliff-pch: drop call to wakeup-disable
authorVaibhav Gupta <vaibhavgupta40@gmail.com>
Mon, 27 Jul 2020 17:29:37 +0000 (22:59 +0530)
committerMark Brown <broonie@kernel.org>
Tue, 28 Jul 2020 16:29:29 +0000 (17:29 +0100)
commit02663d8521d51fef7b349fcb2693660969dddbcd
treeb042308a1a3dc4bc17c42c062e5c5965a2c57f21
parenta1e88a7631027c0f60b40333c064eb5c07c508fa
spi: spi-topcliff-pch: drop call to wakeup-disable

Before generic upgrade, both .suspend() and .resume() were invoking
pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both
states. (Normal trend is .suspend() enables and .resume() disables the
wakeup.)

This was ambiguous and may be buggy. Instead of replicating the legacy
behavior, drop the wakeup-disable call.

Fixes: 0844555930c6 ("spi: spi-topcliff-pch: use generic power management")
Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200727172936.661567-1-vaibhavgupta40@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-topcliff-pch.c