]> git.baikalelectronics.ru Git - kernel.git/commit
binfmt_elf: Uninitialized variable
authorAlan Cox <alan@linux.intel.com>
Fri, 5 Oct 2012 00:13:42 +0000 (17:13 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 5 Oct 2012 18:05:00 +0000 (03:05 +0900)
commit0253ee821ea6877da2cab6dad52a37534aabd6c5
treef8e7cc4128d82433142553a2e67538c1a8edff22
parent4d4261d0fa07e63df669dbd558a0d8001b360bf0
binfmt_elf: Uninitialized variable

load_elf_interp() has interp_map_addr carefully described as
"uninitialized_var" and marked so as to avoid a warning.  However if you
trace the code it is passed into load_elf_interp and then this value is
checked against NULL.

As this return value isn't used this is actually safe but it freaks
various analysis tools that see un-initialized memory addresses being read
before their value is ever defined.

Set it to NULL as a matter of programming good taste if nothing else

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/binfmt_elf.c