]> git.baikalelectronics.ru Git - kernel.git/commit
OF: properties: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 13 Jan 2019 09:44:50 +0000 (10:44 +0100)
committerRob Herring <robh@kernel.org>
Wed, 16 Jan 2019 18:49:53 +0000 (12:49 -0600)
commit014b52ea18475008a151c96299704697b8f8a50b
treebbd798f3fbcf11f9169c166b6c85b51b70f36963
parentfa646b162d3ef558e867708f67bf9def80bdf1b8
OF: properties: add missing of_node_put

Add an of_node_put when the result of of_graph_get_remote_port_parent is
not available.

The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@r exists@
local idexpression e;
expression x;
@@
e = of_graph_get_remote_port_parent(...);
... when != x = e
    when != true e == NULL
    when != of_node_put(e)
    when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: stable@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/property.c