]> git.baikalelectronics.ru Git - kernel.git/commit
nodemask: Fix return values to be unsigned
authorKees Cook <keescook@chromium.org>
Wed, 18 May 2022 20:52:23 +0000 (13:52 -0700)
committerYury Norov <yury.norov@gmail.com>
Fri, 3 Jun 2022 13:52:58 +0000 (06:52 -0700)
commit011cd20c62568c3fd6822eea6e051be4c18da4d7
treeb77c04b230db5c1f8e04d468ba9637427337b815
parent3aba5b4460f7b3e9bb3cefb31a96bf1c824752b8
nodemask: Fix return values to be unsigned

The nodemask routines had mixed return values that provided potentially
signed return values that could never happen. This was leading to the
compiler getting confusing about the range of possible return values
(it was thinking things could be negative where they could not be). Fix
all the nodemask routines that should be returning unsigned
(or bool) values. Silences:

 mm/swapfile.c: In function ‘setup_swap_info’:
 mm/swapfile.c:2291:47: error: array subscript -1 is below array bounds of ‘struct plist_node[]’ [-Werror=array-bounds]
  2291 |                                 p->avail_lists[i].prio = 1;
       |                                 ~~~~~~~~~~~~~~^~~
 In file included from mm/swapfile.c:16:
 ./include/linux/swap.h:292:27: note: while referencing ‘avail_lists’
   292 |         struct plist_node avail_lists[]; /*
       |                           ^~~~~~~~~~~

Reported-by: Christophe de Dinechin <dinechin@redhat.com>
Link: https://lore.kernel.org/lkml/20220414150855.2407137-3-dinechin@redhat.com/
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Yury Norov <yury.norov@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Yury Norov <yury.norov@gmail.com>
include/linux/nodemask.h
lib/nodemask.c