]> git.baikalelectronics.ru Git - kernel.git/commit
sctp: Fix COMM_LOST/CANT_STR_ASSOC err reporting on big-endian platforms
authorPetr Malat <oss@malat.biz>
Fri, 30 Oct 2020 13:26:33 +0000 (14:26 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Nov 2020 23:03:25 +0000 (15:03 -0800)
commit0108749e17d4db9caf9bbf594b6048a0eed89a94
tree85def7a9a56e8cdbdf943ecd85553998509f970d
parenta52dbeac429d6e71642eed6e3c1ee8979bf024d4
sctp: Fix COMM_LOST/CANT_STR_ASSOC err reporting on big-endian platforms

Commit 4df9028de7ce ("sctp: fix some type cast warnings introduced since
very beginning")' broke err reading from sctp_arg, because it reads the
value as 32-bit integer, although the value is stored as 16-bit integer.
Later this value is passed to the userspace in 16-bit variable, thus the
user always gets 0 on big-endian platforms. Fix it by reading the __u16
field of sctp_arg union, as reading err field would produce a sparse
warning.

Fixes: 4df9028de7ce ("sctp: fix some type cast warnings introduced since very beginning")
Signed-off-by: Petr Malat <oss@malat.biz>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Link: https://lore.kernel.org/r/20201030132633.7045-1-oss@malat.biz
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sctp/sm_sideeffect.c