]> git.baikalelectronics.ru Git - kernel.git/commit
net: qrtr: fix memory leaks
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 23 Jul 2021 15:31:32 +0000 (18:31 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Jul 2021 16:48:06 +0000 (17:48 +0100)
commit00cf8392ef2e6f9e0841b83f4d0485081683a135
treeecd9696e9a744d91aa86d0ebadeb2d4b3c4c9637
parentb3e6434980bd4f242145b0d197bed8b85b49ceae
net: qrtr: fix memory leaks

Syzbot reported memory leak in qrtr. The problem was in unputted
struct sock. qrtr_local_enqueue() function calls qrtr_port_lookup()
which takes sock reference if port was found. Then there is the following
check:

if (!ipc || &ipc->sk == skb->sk) {
...
return -ENODEV;
}

Since we should drop the reference before returning from this function and
ipc can be non-NULL inside this if, we should add qrtr_port_put() inside
this if.

The similar corner case is in qrtr_endpoint_post() as Manivannan
reported. In case of sock_queue_rcv_skb() failure we need to put
port reference to avoid leaking struct sock pointer.

Fixes: 391c76519498 ("net: qrtr: Remove receive worker")
Fixes: e1acd3e21749 ("net: Add Qualcomm IPC router")
Reported-and-tested-by: syzbot+35a511c72ea7356cdcf3@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/qrtr/qrtr.c