]> git.baikalelectronics.ru Git - kernel.git/commit
af_unix: Revert 'lock_interruptible' in stream receive code
authorRainer Weikusat <rweikusat@mobileactivedefense.com>
Wed, 16 Dec 2015 20:09:25 +0000 (20:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Dec 2015 20:33:47 +0000 (15:33 -0500)
commit00bdf2588b31603f461100952fe66b53e31c587f
treeb820d7ac997e8b1d4c2505416c7ef7a8c55b74c1
parentd22866222c9d8562b2aabe2b80b57db5a751ebdb
af_unix: Revert 'lock_interruptible' in stream receive code

With 87b25cfc1bf6bd79fba342f6f61262b854b78fa9, the AF_UNIX SOCK_STREAM
receive code was changed from using mutex_lock(&u->readlock) to
mutex_lock_interruptible(&u->readlock) to prevent signals from being
delayed for an indefinite time if a thread sleeping on the mutex
happened to be selected for handling the signal. But this was never a
problem with the stream receive code (as opposed to its datagram
counterpart) as that never went to sleep waiting for new messages with the
mutex held and thus, wouldn't cause secondary readers to block on the
mutex waiting for the sleeping primary reader. As the interruptible
locking makes the code more complicated in exchange for no benefit,
change it back to using mutex_lock.

Signed-off-by: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/unix/af_unix.c