]> git.baikalelectronics.ru Git - kernel.git/commit
i40e/i40evf: Fix handling of boolean logic in polling routines
authorAlexander Duyck <aduyck@mirantis.com>
Mon, 7 Mar 2016 17:29:57 +0000 (09:29 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 5 Apr 2016 08:54:12 +0000 (01:54 -0700)
commit007fb87c8b9d4cd51b07f0e956a4bb6b48d98a34
tree00c8856f8a9959e47381ff3f8e6152d1ffc492cd
parent76359cccf5a165a03ac39c02a725278e70a18bad
i40e/i40evf: Fix handling of boolean logic in polling routines

In the polling routines for i40e and i40evf we were using bitwise operators
to avoid the side effects of the logical operators, specifically the fact
that if the first case is true with "||" we skip the second case, or if it
is false with "&&" we skip the second case.  This fixes an earlier patch
that converted the bitwise operators over to the logical operators and
instead replaces the entire thing with just an if statement since it should
be more readable what we are trying to do this way.

Fixes: dab0fdb94623 ("i40e/i40evf: use logical operators, not bitwise")
Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_txrx.c
drivers/net/ethernet/intel/i40evf/i40e_txrx.c