]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/kprobes: Fix validation of prefixed instructions across page boundary
authorNaveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Wed, 19 May 2021 10:47:17 +0000 (16:17 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 28 May 2021 11:52:42 +0000 (21:52 +1000)
commit00595f8c7f77b27ac1671b5b5dded43a6e2316bf
tree0bc27b73514fbcbcff456603cd3148d3474ba097
parent1bfad7d11a21bd6dbecc3f5e93af70ed4541b213
powerpc/kprobes: Fix validation of prefixed instructions across page boundary

When checking if the probed instruction is the suffix of a prefixed
instruction, we access the instruction at the previous word. If the
probed instruction is the very first word of a module, we can end up
trying to access an invalid page.

Fix this by skipping the check for all instructions at the beginning of
a page. Prefixed instructions cannot cross a 64-byte boundary and as
such, we don't expect to encounter a suffix as the very first word in a
page for kernel text. Even if there are prefixed instructions crossing
a page boundary (from a module, for instance), the instruction will be
illegal, so preventing probing on the suffix of such prefix instructions
isn't worthwhile.

Fixes: 8022f86a546f ("powerpc/kprobes: Don't allow breakpoints on suffixes")
Cc: stable@vger.kernel.org # v5.8+
Reported-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/0df9a032a05576a2fa8e97d1b769af2ff0eafbd6.1621416666.git.naveen.n.rao@linux.vnet.ibm.com
arch/powerpc/kernel/kprobes.c