]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vc4: Allow vblank_disable_immediate on non-fw-kms. (v2)
authorMario Kleiner <mario.kleiner.de@gmail.com>
Thu, 22 Jun 2017 01:28:11 +0000 (03:28 +0200)
committerEric Anholt <eric@anholt.net>
Thu, 22 Jun 2017 18:13:33 +0000 (11:13 -0700)
commit0055c00d7817b5dae182563bf77516429bef28ef
tree9b69f0e6b938f896a8a111e741fed6487af90180
parent4391226959017167d24ceca2435ac6c28dd75618
drm/vc4: Allow vblank_disable_immediate on non-fw-kms. (v2)

With instantaneous high precision vblank timestamping
that updates at leading edge of vblank, the emulated
"hw vblank counter" from vblank timestamping which
increments at leading edge of vblank, and reliable
page flip execution and completion at leading edge
of vblank, we should meet the requirements for fast
vblank irq disable/enable.

Testing against rpi-4.12-rc5 Linux kernel with timing
measurement equipment indicates this works fine,
so allow immediate vblank disable for power saving.

For debugging in case of unexpected trouble, booting
with kernel cmdline option drm.vblankoffdelay=0
would keep vblank irqs on to approximate old behavior.

v2: Respin onto drm-misc-next, per Eric's suggestion.
    Drop !vc4->firmware_kms check, as the firmware_kms
    implementation does not exist in upstream.

Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: Eric Anholt <eric@anholt.net>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: http://patchwork.freedesktop.org/patch/msgid/20170622012811.2139-1-mario.kleiner.de@gmail.com
drivers/gpu/drm/vc4/vc4_kms.c