From fc968aa0131292e22a7c86c9f2cf06481f5b1f14 Mon Sep 17 00:00:00 2001 From: Karthikeyan Periyasamy Date: Wed, 24 Jul 2019 14:46:10 +0530 Subject: [PATCH] mac80211: reject zero MAC address in add station This came up in fuzz testing, and really we don't consider all-zeroes to be a valid MAC address in most places, so also reject it here to avoid confusion later on. Signed-off-by: Karthikeyan Periyasamy Link: https://lore.kernel.org/r/1563959770-21570-1-git-send-email-periyasa@codeaurora.org [rewrite commit message] Signed-off-by: Johannes Berg --- net/mac80211/cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index 4d458067d80d1..10b99b263c4fa 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -1543,7 +1543,7 @@ static int ieee80211_add_station(struct wiphy *wiphy, struct net_device *dev, if (ether_addr_equal(mac, sdata->vif.addr)) return -EINVAL; - if (is_multicast_ether_addr(mac)) + if (!is_valid_ether_addr(mac)) return -EINVAL; sta = sta_info_alloc(sdata, mac, GFP_KERNEL); -- 2.39.5