From f3900ce401dba0296949054c1d70de77ad939434 Mon Sep 17 00:00:00 2001 From: Ian Abbott Date: Wed, 8 Mar 2017 18:44:32 +0000 Subject: [PATCH] staging: comedi: jr3_pci: fix initial range[8] max value `jr3_pci_alloc_spriv()` initializes `spriv->range[8]` to use a maximum value of 65536, but that will be overwritten with 65535 at a later time by `jr3_pci_poll_subdevice()` once the "set full scales" command is complete. The initial setting looks like a mistake. This range is only associated with a couple of dummy channels (channels 56 and 57) to read back the model number and serial number, so no user code should be attempting to convert those numbers to physical units. Just change the initial value to 65535 to match the final value. Signed-off-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/jr3_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c index a21344e1a4c39..e750be39103b0 100644 --- a/drivers/staging/comedi/drivers/jr3_pci.c +++ b/drivers/staging/comedi/drivers/jr3_pci.c @@ -653,7 +653,7 @@ jr3_pci_alloc_spriv(struct comedi_device *dev, struct comedi_subdevice *s) } spriv->range[8].l.length = 1; spriv->range[8].l.range[0].min = 0; - spriv->range[8].l.range[0].max = 65536; + spriv->range[8].l.range[0].max = 65535; spriv->range_table_list[56] = &spriv->range[8].l; spriv->range_table_list[57] = &spriv->range[8].l; -- 2.39.5