From db609a71d5a3ead633932f998aa1ba90d9be13eb Mon Sep 17 00:00:00 2001 From: Jeff Garzik Date: Fri, 14 Dec 2012 09:35:51 -0500 Subject: [PATCH] Revert "pata_octeon_cf: perform host detach, removal on exit" This reverts commit 3ed311f957706f84fb95c768d21172501633473a. Brian Norris writes: > David Daney writes: > I can seem to find it. Without knowing what that does, I would be inclined > to NACK the whole thing. A NACK is probably the right thing. I was mostly converting a few other drivers which used some simple, common patterns to use my new common code, but this driver was missing it altogether. It looks like there may be bigger issues, though, as you point out. > This patch is likely to be incomplete as the driver is also missing the > module_exit() things. > > It might be simpler to just make the driver "bool" instead of "tristate" in > the Kconfig. As noted earlier, I don't have much interest in this driver. I agree that there are some other issues with the driver; I think it leaks memory if it is ever allowed to unload, for one. Feel free to submit an alternative patch to prevent this driver from being built as a module. Signed-off-by: Jeff Garzik --- drivers/ata/pata_octeon_cf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c index d8df93b2a0289..1d61d5d278fa4 100644 --- a/drivers/ata/pata_octeon_cf.c +++ b/drivers/ata/pata_octeon_cf.c @@ -921,7 +921,6 @@ free_cf_port: static struct platform_driver octeon_cf_driver = { .probe = octeon_cf_probe, - .remove = ata_platform_remove_one, .driver = { .name = DRV_NAME, .owner = THIS_MODULE, -- 2.39.5