From d76f012ea8fc0566dcacc067fcaae59d37267ffa Mon Sep 17 00:00:00 2001 From: Jacky Bai Date: Mon, 14 Mar 2022 17:14:26 +0800 Subject: [PATCH] refactor(imx8m): replace magic number with enum type Replace those RDC config related magic numbers with enum type Signed-off-by: Jacky Bai Change-Id: I6245ccfa74d079179dc0f205980c2daf5c7af786 --- plat/imx/imx8m/imx8mm/imx8mm_bl31_setup.c | 6 ++++-- plat/imx/imx8m/imx8mn/imx8mn_bl31_setup.c | 6 ++++-- plat/imx/imx8m/imx8mp/imx8mp_bl31_setup.c | 5 +++-- plat/imx/imx8m/include/imx_rdc.h | 3 ++- 4 files changed, 13 insertions(+), 7 deletions(-) diff --git a/plat/imx/imx8m/imx8mm/imx8mm_bl31_setup.c b/plat/imx/imx8m/imx8mm/imx8mm_bl31_setup.c index 40110d778..71d7497db 100644 --- a/plat/imx/imx8m/imx8mm/imx8mm_bl31_setup.c +++ b/plat/imx/imx8m/imx8mm/imx8mm_bl31_setup.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, ARM Limited and Contributors. All rights reserved. + * Copyright (c) 2019-2022 ARM Limited and Contributors. All rights reserved. * * SPDX-License-Identifier: BSD-3-Clause */ @@ -44,9 +44,11 @@ static const struct aipstz_cfg aipstz[] = { static const struct imx_rdc_cfg rdc[] = { /* Master domain assignment */ - RDC_MDAn(0x1, DID1), + RDC_MDAn(RDC_MDA_M4, DID1), /* peripherals domain permission */ + RDC_PDAPn(RDC_PDAP_UART4, D1R | D1W), + RDC_PDAPn(RDC_PDAP_UART2, D0R | D0W), /* memory region */ diff --git a/plat/imx/imx8m/imx8mn/imx8mn_bl31_setup.c b/plat/imx/imx8m/imx8mn/imx8mn_bl31_setup.c index d4705eeeb..03aafbc5c 100644 --- a/plat/imx/imx8m/imx8mn/imx8mn_bl31_setup.c +++ b/plat/imx/imx8m/imx8mn/imx8mn_bl31_setup.c @@ -1,5 +1,5 @@ /* - * Copyright 2019-2020 NXP + * Copyright 2019-2022 NXP * * SPDX-License-Identifier: BSD-3-Clause */ @@ -41,9 +41,11 @@ static const struct aipstz_cfg aipstz[] = { static const struct imx_rdc_cfg rdc[] = { /* Master domain assignment */ - RDC_MDAn(0x1, DID1), + RDC_MDAn(RDC_MDA_M7, DID1), /* peripherals domain permission */ + RDC_PDAPn(RDC_PDAP_UART4, D1R | D1W), + RDC_PDAPn(RDC_PDAP_UART2, D0R | D0W), /* memory region */ RDC_MEM_REGIONn(16, 0x0, 0x0, 0xff), diff --git a/plat/imx/imx8m/imx8mp/imx8mp_bl31_setup.c b/plat/imx/imx8m/imx8mp/imx8mp_bl31_setup.c index 22fbd5e4b..d6e4cdd92 100644 --- a/plat/imx/imx8m/imx8mp/imx8mp_bl31_setup.c +++ b/plat/imx/imx8m/imx8mp/imx8mp_bl31_setup.c @@ -1,5 +1,5 @@ /* - * Copyright 2020 NXP + * Copyright 2020-2022 NXP * * SPDX-License-Identifier: BSD-3-Clause */ @@ -42,9 +42,10 @@ static const struct aipstz_cfg aipstz[] = { static const struct imx_rdc_cfg rdc[] = { /* Master domain assignment */ - RDC_MDAn(0x1, DID1), + RDC_MDAn(RDC_MDA_M7, DID1), /* peripherals domain permission */ + RDC_PDAPn(RDC_PDAP_UART2, D0R | D0W), /* memory region */ diff --git a/plat/imx/imx8m/include/imx_rdc.h b/plat/imx/imx8m/include/imx_rdc.h index e25b0e6d4..a6e10a7b7 100644 --- a/plat/imx/imx8m/include/imx_rdc.h +++ b/plat/imx/imx8m/include/imx_rdc.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, NXP. All rights reserved. + * Copyright (c) 2019-2022 NXP. All rights reserved. * * SPDX-License-Identifier: BSD-3-Clause */ @@ -9,6 +9,7 @@ #include +#include #include #define MDAn(x) (IMX_RDC_BASE + 0x200 + (x) * 4) -- 2.39.5