From c3ae7da02dd8b358239dde47c3325e333af81056 Mon Sep 17 00:00:00 2001 From: Yann Gautier Date: Mon, 28 Nov 2022 14:56:58 +0100 Subject: [PATCH] fix(st-clock): use Boolean type for tests This corrects MISRA C2012-14.4 The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type. Signed-off-by: Yann Gautier Change-Id: Id217d3da223caf75cd0439d7ce11c9efab87b4d2 --- drivers/st/clk/clk-stm32-core.c | 4 ++-- drivers/st/clk/clk-stm32mp13.c | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/st/clk/clk-stm32-core.c b/drivers/st/clk/clk-stm32-core.c index bb0312533..d166d5472 100644 --- a/drivers/st/clk/clk-stm32-core.c +++ b/drivers/st/clk/clk-stm32-core.c @@ -519,7 +519,7 @@ static uint8_t _stm32_clk_get_flags(struct stm32_clk_priv *priv, int id) bool _stm32_clk_is_flags(struct stm32_clk_priv *priv, int id, uint8_t flag) { - if (_stm32_clk_get_flags(priv, id) & flag) { + if ((_stm32_clk_get_flags(priv, id) & flag) != 0U) { return true; } @@ -549,7 +549,7 @@ static int _clk_stm32_enable_core(struct stm32_clk_priv *priv, int id) } if (parent != CLK_IS_ROOT) { ret = _clk_stm32_enable_core(priv, parent); - if (ret) { + if (ret != 0) { return ret; } } diff --git a/drivers/st/clk/clk-stm32mp13.c b/drivers/st/clk/clk-stm32mp13.c index c96092899..05e9ad75e 100644 --- a/drivers/st/clk/clk-stm32mp13.c +++ b/drivers/st/clk/clk-stm32mp13.c @@ -1119,7 +1119,7 @@ static int stm32_clk_configure_clk(struct stm32_clk_priv *priv, uint32_t data) return ret; } - if (enable) { + if (enable != 0) { clk_stm32_enable_call_ops(priv, clk_id); } else { clk_stm32_disable_call_ops(priv, clk_id); @@ -1450,7 +1450,7 @@ static int _clk_stm32_pll_init(struct stm32_clk_priv *priv, int pll_idx, /* Configure PLLs source */ ret = stm32_clk_configure_mux(priv, pll_conf->vco.src); - if (ret) { + if (ret != 0) { return ret; } @@ -1485,7 +1485,7 @@ static int clk_stm32_pll_init(struct stm32_clk_priv *priv, int pll_idx) { struct stm32_pll_dt_cfg *pll_conf = clk_stm32_pll_get_pdata(pll_idx); - if (pll_conf->vco.status) { + if (pll_conf->vco.status != 0U) { return _clk_stm32_pll_init(priv, pll_idx, pll_conf); } @@ -1497,22 +1497,22 @@ static int stm32_clk_pll_configure(struct stm32_clk_priv *priv) int err = 0; err = clk_stm32_pll_init(priv, _PLL1); - if (err) { + if (err != 0) { return err; } err = clk_stm32_pll_init(priv, _PLL2); - if (err) { + if (err != 0) { return err; } err = clk_stm32_pll_init(priv, _PLL3); - if (err) { + if (err != 0) { return err; } err = clk_stm32_pll_init(priv, _PLL4); - if (err) { + if (err != 0) { return err; } -- 2.39.5