From ac152fa0b126081dc877ba891ed1b6b33eb0c3c5 Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Thu, 28 Jul 2016 15:48:59 -0700 Subject: [PATCH] zsmalloc: Delete an unnecessary check before the function call "iput" iput() tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Link: http://lkml.kernel.org/r/559cf499-4a01-25f9-c87f-24d906626a57@users.sourceforge.net Signed-off-by: Markus Elfring Reviewed-by: Sergey Senozhatsky Acked-by: Minchan Kim Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- mm/zsmalloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index cd2a81e8b4295..b0bc023d25c53 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -2174,8 +2174,7 @@ static int zs_register_migration(struct zs_pool *pool) static void zs_unregister_migration(struct zs_pool *pool) { flush_work(&pool->free_work); - if (pool->inode) - iput(pool->inode); + iput(pool->inode); } /* -- 2.39.5