From 948025e5491334b008714707176538f3a9ca2781 Mon Sep 17 00:00:00 2001 From: Hui Wang Date: Thu, 29 May 2014 15:59:17 +0800 Subject: [PATCH] Revert "ALSA: hda - drop def association and sequence from pinconf comparing" This reverts commit 4d0c6d925f3dd7c6aac9f486c9a6ad1f722477b2. Dropping the def association and sequence from pinconf comparing is a bit risky, It will introduce a greater risk of catching unwanted machines. And in addition, so far no BIOS experts give us an explicit answer whether it makes senses to compare these two fields or not. For safety reason, we revert this commit. Signed-off-by: Hui Wang Signed-off-by: Takashi Iwai --- sound/pci/hda/hda_auto_parser.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c index 3cf913772e9ba..b684c6e4f3012 100644 --- a/sound/pci/hda/hda_auto_parser.c +++ b/sound/pci/hda/hda_auto_parser.c @@ -844,8 +844,7 @@ static bool pin_config_match(struct hda_codec *codec, { for (; pins->nid; pins++) { u32 def_conf = snd_hda_codec_get_pincfg(codec, pins->nid); - u32 mask = 0xffffff00; - if ((pins->val & mask) != (def_conf & mask)) + if (pins->val != def_conf) return false; } return true; -- 2.39.5