From 852378fd60d8cc536799639774f1e4ffe124131d Mon Sep 17 00:00:00 2001 From: Andrew Davis Date: Thu, 28 Apr 2022 09:39:02 -0500 Subject: [PATCH] feat(ti): add sub and patch version number support Although we do not use these for anything today, they are returned in this structure and the struct's definition should match. While here fix a couple comment typos. Signed-off-by: Andrew Davis Change-Id: Iac4ec999b44e703e600bde93b0eee83753566876 --- .../ti/k3/common/drivers/sec_proxy/sec_proxy.h | 2 +- .../k3/common/drivers/ti_sci/ti_sci_protocol.h | 18 ++++++++++++++++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/plat/ti/k3/common/drivers/sec_proxy/sec_proxy.h b/plat/ti/k3/common/drivers/sec_proxy/sec_proxy.h index f4b0b4bac..4005102f0 100644 --- a/plat/ti/k3/common/drivers/sec_proxy/sec_proxy.h +++ b/plat/ti/k3/common/drivers/sec_proxy/sec_proxy.h @@ -53,7 +53,7 @@ struct k3_sec_proxy_msg { }; /** - * k3_sec_proxy_send() - Send data over a Secure Proxy thread + * k3_sec_proxy_clear_rx_thread() - Clear a receive Secure Proxy thread * @id: Channel Identifier * @msg: Pointer to k3_sec_proxy_msg * diff --git a/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h b/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h index 1b1a91033..36909f57d 100644 --- a/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h +++ b/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h @@ -73,18 +73,30 @@ struct ti_sci_msg_hdr { } __packed; /** - * struct ti_sci_msg_resp_version - Response for a message + * struct ti_sci_msg_version_req - Request for firmware version information + * @hdr: Generic header + * + * Request for TI_SCI_MSG_VERSION + */ +struct ti_sci_msg_req_version { + struct ti_sci_msg_hdr hdr; +} __packed; + +/** + * struct ti_sci_msg_resp_version - Response for firmware version information * @hdr: Generic header * @firmware_description: String describing the firmware * @firmware_revision: Firmware revision * @abi_major: Major version of the ABI that firmware supports * @abi_minor: Minor version of the ABI that firmware supports + * @sub_version: Sub-version number of the firmware + * @patch_version: Patch-version number of the firmware. * * In general, ABI version changes follow the rule that minor version increments * are backward compatible. Major revision changes in ABI may not be * backward compatible. * - * Response to a generic message with message type TI_SCI_MSG_VERSION + * Response to request TI_SCI_MSG_VERSION */ struct ti_sci_msg_resp_version { struct ti_sci_msg_hdr hdr; @@ -93,6 +105,8 @@ struct ti_sci_msg_resp_version { uint16_t firmware_revision; uint8_t abi_major; uint8_t abi_minor; + uint8_t sub_version; + uint8_t patch_version; } __packed; /** -- 2.39.5