From 566739211dabcc0bb45b26324a4f70789cfd060a Mon Sep 17 00:00:00 2001 From: "David S. Miller" Date: Tue, 14 Dec 2021 12:53:41 +0000 Subject: [PATCH] Revert "pktgen: use min() to make code cleaner" This reverts commit 9609c97a3155aa66e603a898fff18fdc65ccf6df. Causes build warnings. Signed-off-by: David S. Miller --- net/core/pktgen.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 239effb42b617..560a5e712dc32 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2778,7 +2778,8 @@ static void pktgen_finalize_skb(struct pktgen_dev *pkt_dev, struct sk_buff *skb, } i = 0; - frag_len = min(datalen / frags, PAGE_SIZE); + frag_len = (datalen/frags) < PAGE_SIZE ? + (datalen/frags) : PAGE_SIZE; while (datalen > 0) { if (unlikely(!pkt_dev->page)) { int node = numa_node_id(); @@ -2795,7 +2796,7 @@ static void pktgen_finalize_skb(struct pktgen_dev *pkt_dev, struct sk_buff *skb, /*last fragment, fill rest of data*/ if (i == (frags - 1)) skb_frag_size_set(&skb_shinfo(skb)->frags[i], - min(datalen, PAGE_SIZE)); + (datalen < PAGE_SIZE ? datalen : PAGE_SIZE)); else skb_frag_size_set(&skb_shinfo(skb)->frags[i], frag_len); datalen -= skb_frag_size(&skb_shinfo(skb)->frags[i]); -- 2.39.5