From 5064ced0388d0cda9e5dfd32dbece9f1f2e9668a Mon Sep 17 00:00:00 2001 From: Christophe Leroy Date: Tue, 30 Oct 2018 15:05:53 -0700 Subject: [PATCH] checkpatch: remove GCC_BINARY_CONSTANT warning This warning was there to avoid the use of 0bxxx values as they are not supported by gcc prior to v4.3 Since 46ed35d9f3fa8 ("Raise the minimum required gcc version to 4.6"), it's not an issue anymore and using such values can increase readability of code. Joe said: : Seems sensible as the other compilers also support binary literals from : relatively old versions. : http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3472.pdf : https://software.intel.com/en-us/articles/c14-features-supported-by-intel-c-compiler Link: http://lkml.kernel.org/r/392eeae782302ee8812a3c932a602035deed1609.1535351453.git.christophe.leroy@c-s.fr Signed-off-by: Christophe Leroy Cc: Joe Perches Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- scripts/checkpatch.pl | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 161b0224d6ae9..c883ec55654fb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4934,17 +4934,6 @@ sub process { while ($line =~ m{($Constant|$Lval)}g) { my $var = $1; -#gcc binary extension - if ($var =~ /^$Binary$/) { - if (WARN("GCC_BINARY_CONSTANT", - "Avoid gcc v4.3+ binary constant extension: <$var>\n" . $herecurr) && - $fix) { - my $hexval = sprintf("0x%x", oct($var)); - $fixed[$fixlinenr] =~ - s/\b$var\b/$hexval/; - } - } - #CamelCase if ($var !~ /^$Constant$/ && $var =~ /[A-Z][a-z]|[a-z][A-Z]/ && -- 2.39.5