From 0133eafc4858a6d92d5c735025ca7a3f4d1d7db6 Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Tue, 13 Mar 2012 11:21:20 +1100 Subject: [PATCH] md/raid10: remove unnecessary smp_mb() from end_sync_write Recent commit 91674012c6edcd5e68c (md/raid10: Allow replacement device ...) added an smp_mb in end_sync_write. This was to close a possible race with raid10_remove_disk. However there is no such race as it is never attempted to remove a disk while resync (or recovery) is happening. so the smp_mb is just noise. Signed-off-by: NeilBrown --- drivers/md/raid10.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 58c44d6453a0b..1a19c962f860a 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1682,10 +1682,8 @@ static void end_sync_write(struct bio *bio, int error) d = find_bio_disk(conf, r10_bio, bio, &slot, &repl); if (repl) rdev = conf->mirrors[d].replacement; - if (!rdev) { - smp_mb(); + else rdev = conf->mirrors[d].rdev; - } if (!uptodate) { if (repl) -- 2.39.5