]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (applesmc) avoid overlong udelay()
authorArnd Bergmann <arnd@arndb.de>
Wed, 27 May 2020 13:51:57 +0000 (15:51 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 27 May 2020 16:18:13 +0000 (09:18 -0700)
commitf27412d1e62905ee3776ef4e5f7148169d4590eb
treeee91b58d6b14c7e435e4550025c6fc1b4668f0ee
parent6db24c752781b755ceeda7c41141ca01045cce7d
hwmon: (applesmc) avoid overlong udelay()

Building this driver with "clang -O3" produces a link error
after the compiler partially unrolls the loop and 256ms
becomes a compile-time constant that triggers the check
in udelay():

ld.lld: error: undefined symbol: __bad_udelay
>>> referenced by applesmc.c
>>>               hwmon/applesmc.o:(read_smc) in archive drivers/built-in.a

I can see no reason against using a sleeping function here,
as no part of the driver runs in atomic context, so instead use
usleep_range() with a wide range and use jiffies for the
end condition.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20200527135207.1118624-1-arnd@arndb.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/applesmc.c