]> git.baikalelectronics.ru Git - kernel.git/commit
sysrq: Use panic() to force a crash
authorMatthias Kaehlcke <mka@chromium.org>
Thu, 20 Sep 2018 17:12:53 +0000 (10:12 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Nov 2018 10:16:35 +0000 (11:16 +0100)
commite67800bc030c700de60198da46f501817ffd6b0e
treeb1cab8b656ee5361cabb7a61327681b6c23aec88
parent6859aced5a4c26c885ac206eceaae4624e9b1866
sysrq: Use panic() to force a crash

sysrq_handle_crash() currently forces a crash by dereferencing a
NULL pointer, which is undefined behavior in C. Just call panic()
instead, which is simpler and doesn't depend on compiler specific
handling of the undefined behavior.

Remove the comment on why the RCU lock needs to be released, it isn't
accurate anymore since the crash now isn't handled by the page fault
handler (for reference: the comment was added by commit 39471e57be05
("sysrq: Fix warning in sysrq generated crash.")). Releasing the lock
is still good practice though.

Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/sysrq.c