]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: fix up non-directory creation in SGID directories
authorChristoph Hellwig <hch@lst.de>
Sat, 23 Jan 2021 00:48:18 +0000 (16:48 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Sat, 23 Jan 2021 00:54:49 +0000 (16:54 -0800)
commitdd9241e55aaeab7fe40a1dd1f386b9c03ff521fe
tree49101114f070468688ccc7896db67d792cd92b1d
parentef8a324352148f01f6e9218bba22a9fdb5d3753a
xfs: fix up non-directory creation in SGID directories

XFS always inherits the SGID bit if it is set on the parent inode, while
the generic inode_init_owner does not do this in a few cases where it can
create a possible security problem, see commit b7c7b802a3ed
("Fix up non-directory creation in SGID directories") for details.

Switch XFS to use the generic helper for the normal path to fix this,
just keeping the simple field inheritance open coded for the case of the
non-sgid case with the bsdgrpid mount option.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/xfs_inode.c