]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: ufs: core: Tidy up WB configuration code
authorYue Hu <huyue2@yulong.com>
Thu, 18 Mar 2021 09:55:36 +0000 (17:55 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 19 Mar 2021 02:33:48 +0000 (22:33 -0400)
commitd3f2c7a5a4136ca796cb2c4cddb9d6560f299aad
tree576e70cd24fd3ab3f14767890d4dd33fb7a0e51e
parent9ba5992e6545ad09a3bdae67bf22294c0e4e3ebe
scsi: ufs: core: Tidy up WB configuration code

There are similar code implementations for WB configuration in
ufshcd_wb_{ctrl, toggle_flush_during_h8, toggle_flush}. Extract the common
parts to create a new helper with a flag parameter to reduce code
duplication.

Meanwhile, rename ufshcd_wb_ctrl() to ufshcd_wb_toggle() for better
readability. And remove unnecessary log messages from ufshcd_wb_config()
since relevant toggle function will emit messages. Also change
ufshcd_wb_toggle_flush{__during_h8} to void type accordingly.

Link: https://lore.kernel.org/r/20210318095536.2048-1-zbestahu@gmail.com
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Yue Hu <huyue2@yulong.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufs-sysfs.c
drivers/scsi/ufs/ufshcd.c
drivers/scsi/ufs/ufshcd.h